#28: Check email validity when linking existing PNID #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a check after the username/password check to ensure the submitted email matches the user's email. Fixes: PretendoNetwork#28
JohnodonCode
changed the title
this didn't make it into the original commit somehow
middleware is used outside of initial link, so skip checking email if email header is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #28
Changes:
This commit adds a check after the username/password check to ensure the submitted email matches the user's email.
The error code (022-2613 / 1105 in source code) is correct for any case where username/password/email are incorrect according to Nintendo.